[IRCServices Coding] still having smtp_readline problems

[Andrew Church]

     OR is correct.  The code reads "repeat the loop if -EITHER- (1) we
haven't seen an end-of-line character (i.e. this line hasn't been
completely read) -OR- we have read the line completely, but si->replychar
(the fourth character of the line) is not a space."  The second condition
is required to handle multiple-line SMTP replies, in which the fourth
character of every line except the last one is '-', and the fourth
character of the last line is a space.

     Maybe your mail server is broken?

  --Andrew Church
    achurch at achurch.org
    http://achurch.org/

>
>from smtp_readline, modules/mail/smtp.c:202
> if (!have_eol || si->replychar != ' ')
>     return;
>
>Should that not be AND? If we dont have the end of line and the socket's
>replychar isnt a space, return and read again(?).  I dont know why anyone
>else isn't having problems with sendmail functions.. maybe its my mail
>server.  When this code executes, si->replychar == '-'.  Change it to && or
>comment it out, I get mail.
>
>FreeBSD raider 4.4-20010827-RC2 FreeBSD 4.4-20010827-RC2 #4: Fri Nov 16
>14:57:04
> EST 2001     root at raider:/usr/obj/usr/src/sys/BG1  i386
>
>ircservices-5.0pre0 services.bstu.dhs.org build #14, compiled Wed May 29
>19:12:33 EDT 2002
>
>-- Ben Goldstein (beng at nc.rr.com)
>
>
>
>
>------------------------------------------------------------------
>To unsubscribe or change your subscription options, visit:
>http://www.ircservices.za.net/mailman/listinfo/ircservices-coding