[IRCServices] Little remote WHOIS formal bug

[John Binder]

OK, where can I send the .diff if I will fix it?

Janos Binder


----- Original Message -----
From: "Andrew Church" <achurch at achurch.org>
To: <ircservices at ircservices.za.net>
Sent: Monday, November 19, 2001 9:20 PM
Subject: Re: [IRCServices] Little remote WHOIS formal bug


> >I've just found this reply via whois from services:
> >:services.abc.xyz 311 janos operserv services services.abc.xyz :Operator
> >Server
> >>From server:
> >:irc.abc.xyz 311 janos OperServ services services.abc.xyz * :Operator
Server
> >So the * is missing from the source.
>
>      This is already fixed for version 5.0.
>
> >And the last line is also buggy in void m_whois, it should be:
> >        'send_cmd(ServerName, "318 %s %s End of /WHOIS response.",
source,
> >av[0])'
> >
> >For extra another line should be added (oper numeric) and it should be:
> >        'send_cmd(ServerName, "313 %s %s :is a Network Service", source,
> >av[0])' (or "an IRC Operator")  - but this is only optional , and it
should
> >be for clients/scripts to detect services as a "super-user". (Scripts and
> >clients only watch the numeric in the most cases)
>
>      These will be added for version 5.0.  I may backport the fix to 4.5
> once 5.0 has been finished.
>
> >"/whois services.abc.xyz notexistantuser" is also affected:
> >    'send_cmd(ServerName, "401 %s %s :No such service.", source, av[0]);'
> >Sometimes it breaks some client, it should be two lines:
> >    'send_cmd(ServerName, "401 %s %s :No such nick/channel.", source,
> >av[0]);'
> >    'send_cmd(ServerName, "318 End of /WHOIS response.");'
> >But the last bug can be found rarely.
>
>      I'd consider this a client bug.
>
>   --Andrew Church
>     achurch at achurch.org
>     http://achurch.org/
> -----------------------------------------------------------
> To unsubscribe, mail ircservices-request at ircservices.za.net
> with the word UNSUBSCRIBE in the subject of the mail.
> http://www.ircservices.za.net/mailman/listinfo/ircservices
>
>