[IRCServices] Possible bug in version 5.0.63

[Andrew Church]

Thanks for the additional information.  Unfortunately, it's not very
helpful to me, because it suggests Services is crashing at a point where
the code specifically has checks to avoid a crash.  It does look like
something is happening to the autokills from the AKILLCHAN command, but
I assume that when you did the "akill list", they looked normal?

If you can generate a core dump (recompile after running the configure
script with the "-dumpcore" option) and send it to me along with your
executable file and any files in the "modules" subdirectory of the data
directory (if such a subdirectory exists), I may be able to get a little
more information on the problem.  You can also try removing the vhost
module and seeing if the problem goes away, if that won't cause undue
disturbance on your network.  Otherwise, I think the best recommendation
I can offer at this point is to upgrade to version 5.1; there have been
numerous internal changes since 5.0, so if something inside Services is
indeed at fault, it's possible that it's been fixed.

  --Andrew Church
    achurch at achurch.org
    http://achurch.org/

>The only added module we're using is vhost (Automatic vhosting (Hostserv)
>main module.  Based on code (c) Andrew Kempe (TheShadow)).  All akills
>appeared to be in the correct format when listed.  We were able to reproduce
>the crash and generate a core dump.  Here is the relevant information.
>
>1.  Version: ircservices-5.0.63 services.afterx.net build #2, compiled Thu
>Mar 6 15:52:12 CST 2008
>
>2.  Version: Unreal3.2.7. bellevue.tx.us.afterx.net FhinXOoZE3 [FreeBSD
>7.0-RELEASE FreeBSD 7.0-RELEASE #0: Sun Feb 24 19:59:52 UTC 2008
>root at logan.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386=2309]
>
>3.  Set an akill on a channel (command used was os akillchan kill +1h $0
>Bots not welcome here).  Note only 5 users were banned from this channel.
>
>4.  Log output:
>[Jul 01 07:59:46 2008] operserv/main: tr: akillchan kill +15m #reefaholics
>Bots not welcome here
>[Jul 01 07:59:57 2008] operserv/main: tr: akill list
>[Jul 01 08:18:06 2008] operserv/akill: BUG: (cancel_akill) Missing @ in
>mask: *
>[Jul 01 08:18:06 2008] operserv/akill: BUG: (cancel_akill) Missing @ in
>mask: *
>[Jul 01 08:18:06 2008] database/version4: del_maskdata(): invalid index 3
>for type 0 at 0x283e93d8
>[Jul 01 08:20:26 2008] operserv/akill: BUG: (cancel_akill) Missing @ in
>mask: *
>
>5.  bt output:
>#0  0x28433416 in check_expire_nick (ni=0x28386200) at
>modules/nickserv/util.c:198
>#1  0x281e98e8 in next_nickinfo () at modules/database/version4.c:150
>#2  0x281e9924 in first_nickinfo () at modules/database/version4.c:150
>#3  0x281eb16c in sync_nick_db (dbname=0x282032a0 "nick.db") at
>modules/database/version4.c:620
>#4  0x2842ae93 in do_save_data () at modules/nickserv/main.c:220
>#5  0x0805ab20 in call_callback_5 (module=0x806c8e0, id=6, arg1=0x0,
>arg2=0x0, arg3=0x0, arg4=0x0, arg5=0x0) at modules.c:705
>#6  0x08056283 in do_save_data () at main.c:200
>#7  0x08056465 in main (ac=1, av=0xbfbfecc8, envp=0xbfbfecd0) at main.c:251