[IRCServices Coding] Re: [PATCH] Fix of rogue unescaped backtick in
configure in 5.0.24
arathorn at theonering.net
Fri Nov 14 18:05:19 PST 2003
Hmm, turns out that I was a little premature in sending in that one-line
patch - unless I'm completely missing something, the configure script
doesn't actually end up setting the CC or DEF_CC_FLAGS variables after
warning about deprecation. Not sure whether this is because the
deprecation is being enforced more strongly than the warnings suggest, but
I expanded the tweak to the following in order to get it to build
sensibly. For what it's worth, gcc 2.95.4 has never presented any
problems for me with ircservices (since 4.3.3 or so) - so perhaps it might
also be considerable as 'officially supported' in addition to 2.95.3 and
>3.2? Debian stable has a fairly decent reputation, after all.
diff -ur ircservices-5.0.24/configure ircservices-5.0.24-fixed/configure
--- ircservices-5.0.24/configure Wed Nov 5 01:46:59 2003
+++ ircservices-5.0.24-fixed/configure Fri Nov 14 21:01:23 2003
@@ -875,7 +875,7 @@
elif test $vmajor -lt 3 -a $version != 2.95.3 || test $vmajor = 3 -a $vminor -lt 2 ; then
-WARNING: Your version of GCC was detected as `$version'. As of Services
+WARNING: Your version of GCC was detected as \`$version'. As of Services
5.0.23, versions of GCC earlier than 3.2, other than 2.95.3,
have been deprecated. This and future releases of Services 5.0
will still work, though some error messages will lose
@@ -885,6 +885,9 @@
echo2 "Press Enter to continue: "
+ DEF_CC_FLAGS=`def_cc_flags $CC`
+ log using \`gcc\'
else # version okay
echo "great, found gcc!"
Matthew Hodgson arathorn at theonering.net Tel: +44 7968 722968
Arathorn: Co-Sysadmin, TheOneRing.net®
On Sat, 15 Nov 2003, Andrew Church wrote:
> Thanks, fixed. Silly little details...
> (For the record, I use a homebrew mail reader which can't handle
> attachments. If I do get attachments I can decode them with pine, but I
> prefer patches inline so I can look at them without having to do so.)
> --Andrew Church
> achurch at achurch.org
> >Well, I just had another chance to look more carefully at the configure
> >script - looks like there's a rogue unescaped backtick in the deprecation
> >warning text block:
> >diff -ur ircservices-5.0.24-orig/configure ircservices-5.0.24/configure
> >--- ircservices-5.0.24-orig/configure Wed Nov 5 01:46:59 2003
> >+++ ircservices-5.0.24/configure Fri Nov 14 17:04:08 2003
> >@@ -875,7 +875,7 @@
> > elif test $vmajor -lt 3 -a $version != 2.95.3 || test $vmajor = 3 -a $vminor -lt 2 ; then
> > cat <<EOT
> >-WARNING: Your version of GCC was detected as `$version'. As of Services
> >+WARNING: Your version of GCC was detected as \`$version'. As of Services
> > 5.0.23, versions of GCC earlier than 3.2, other than 2.95.3,
> > have been deprecated. This and future releases of Services 5.0
> > will still work, though some error messages will lose
> >(due to pine insisting on base64'ing mime attachments, i haven't attached
> >the file as Andrew's mail system doesn't seem to approve of base64. -
> >apologies if this mail shows up twice for anyone.)
> >Matthew Hodgson arathorn at theonering.net Tel: +44 7968 722968
> > Arathorn: Co-Sysadmin, TheOneRing.net®
> >On Wed, 12 Nov 2003, Arathorn wrote:
> >> Hi Andy,
> >> Just tried to upgrade to 5.0.24 on my Debian Woody production server
> >> running gcc 2.95.4. I appreciate that this is <3.2 and !=2.95.3, but I
> >> didn't expect ./configure to completely keel over on me (and hoped to be
> >> able to use a -force configure option of some kind to get it to compile
> >> anyway).
> >> Here's the stderr & stdio - the configure.log is attached:
> >> pe1650 18# gcc -v
> >> Reading specs from /usr/lib/gcc-lib/i386-linux/2.95.4/specs
> >> gcc version 2.95.4 20011002 (Debian prerelease)
> >> pe1650 19# ./configure -ignore-cache
> >> Beginning IRC Services configuration.
> >> In what directory do you want the binaries to be installed?
> >> Press Return for the default, or enter a new value.
> >> [/usr/local/sbin] /usr/local/sbin/ircservices-5.0.24-unr
> >> Where do you want the data files to be installed?
> >> [/usr/local/sbin/ircservices-5.0.24-unr/lib] /usr/local/lib/ircservices-5.0
> >> End of interactive configuration.
> >> Checking sanity of /bin/sh... high.
> >> Searching for a suitable compiler... ./configure: command substitution:
> >> line 1: unexpected EOF while looking for matching `''
> >> ./configure: command substitution: line 8: syntax error: unexpected end of file
> >> WARNING: Your version of GCC was detected as Press Enter to continue:
> >> Testing default compiler flags ()... no luck! Using no flags.
> >> If you know what flags you want, use the -cflags option to configure.
> >> Let's see what libraries we need...
> >> Checking if we can use dynamic modules... no.
> >> Checking whether ranlib exists... yes.
> >> Looking for an 8-bit integer type...
> >> *** WHOA THERE! ***
> >> We suddenly couldn't compile using the C compiler we already tested!
> >> The command line we used was:
> >> conf-tmp/test.c -o conf-tmp/test
> >> Please try to fix this; if you can't, mail achurch at achurch.org
> >> with information about your system, the output from this script,
> >> and the `configure.log' file generated by this script.
> >> ________________________________________________________________
> >> Matthew Hodgson arathorn at theonering.net Tel: +44 7968 722968
> >> Arathorn: Co-Sysadmin, TheOneRing.net®
> >> On Tue, 11 Nov 2003, Andrew Church wrote:
> >> > Services 5.0.24 has been released, and can be downloaded from:
> >> >
> >> > ftp://ftp.esper.net/ircservices/ (USA, California)
> >> >
> >> > d8f808b04744e9db365ebb23f7d04078 ircservices-5.0.24.tar.gz
> >> > e2415db90e2c9f3391268b8d48ef40d1 ircservices-5.0.24.diff.gz
> >> > 07d0785f095de88f87de8b4d97024558 ircservices-5.0.24-1.i386.rpm
> >> > 0235352278f534a818699281fcc7ba83 ircservices_5.0.24-1_i386.deb
> >> >
> >> > ftp.ircservices.za.net and the other mirrors should have it shortly.
> >> >
> >> > This release includes a workaround for those who were unable to
> >> > compile 5.0.23; however, please note that being unable to compile means
> >> > that your compiler is outdated, and you should upgrade it (or have the
> >> > server administrator upgrade it) as soon as possible. Support for such
> >> > compilers will be removed entirely in a future version.
> >> >
> >> > Changes in version 5.0.24
> >> > -------------------------
> >> > 2003/11/11 Fixed a warning in convert-db compilation.
> >> > 2003/11/11 Fixed bugs in convert-db causing some nickname and channel
> >> > settings (timezone, language, channel and memo limits)
> >> > to not be initialized properly.
> >> > 2003/11/11 Added -tzfile, -no-timezones, and -reset-memo-limits
> >> > options to the Cygnus database converter in convert-db.
> >> > 2003/11/05 Databases can now be exported in XML from the command line
> >> > (-export option).
> >> > 2003/11/05 GCC versions earlier than 3.2 (except 2.95.3) are now
> >> > deprecated. Variadic macros workaround added for
> >> > problem reported by Ali Sor <alisor at softhome.net>
> >> > 2003/11/05 Channel last-used time is now updated properly for the
> >> > first user to enter the channel if the user has auto-op
> >> > privileges. Reported by <saman at alkol.org>
> >> >
> >> > --Andrew Church
> >> > achurch at achurch.org
> >> > http://achurch.org/
> >> > ------------------------------------------------------------------
> >> > To unsubscribe or change your subscription options, visit:
> >> > http://www.ircservices.za.net/mailman/listinfo/ircservices
> >> >
> >> >